Merged
Conversation
Contributor
|
Will it be possible to compare the SQL functional test time to completion? |
Member
Author
|
We can always do a simple manual run offline, that's likely more reliable anyway than looking at CI times - do you want to do that? |
roji
commented
Jul 26, 2025
|
|
||
| <ItemGroup> | ||
| <PackageReference Include="Microsoft.Data.SqlClient" /> | ||
| <PackageReference Include="Microsoft.SqlServer.Types" /> |
Member
Author
There was a problem hiding this comment.
I added this in #36383 under the mistaken impression that the new SqlVector type lives in Microsoft.SqlServer.Types, but it seems to be in Microsoft.Data.SqlClient - so reverting.
roji
commented
Jul 26, 2025
| : y is not null && (x.IsNull | ||
| ? y.IsNull | ||
| : !y.IsNull && x.Memory.Span == y.Memory.Span); | ||
| => x is SqlVector<float> v1 && y is SqlVector<float> v2 |
Member
Author
There was a problem hiding this comment.
Note that SqlVector was changed to be a readonly struct in the GA version of SqlClient.
Contributor
|
@roji Let me just do that! |
cincuranet
approved these changes
Jul 28, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
/cc @artl93